sql: accept WITH (WAIT ...) on ALTER CLUSTER unconditionally - #38627
Draft
aljoscha wants to merge 1 commit into
Draft
sql: accept WITH (WAIT ...) on ALTER CLUSTER unconditionally#38627aljoscha wants to merge 1 commit into
aljoscha wants to merge 1 commit into
Conversation
Graceful cluster reconfiguration has been behind the `enable_zero_downtime_cluster_reconfiguration` feature flag, default off, so the `WITH (WAIT ...)` surface is rejected at plan time unless a deployment turns it on. The controller record is now the only managed-cluster reshape path, which leaves the flag controlling only whether users can express its deadline and timeout behavior. Remove the flag and planner gate. The two rejections that share the code path stay: a `WAIT` without a replica-shape change, and a `WAIT` on an unmanaged cluster. Every test that used the surface enabled the flag itself, so those statements go. In a mixed-version run some phases execute against a released binary that still enforces the gate, so `get_minimal_system_parameters` pins the flag on below v26.41 instead. The docs drop the private-preview badges because the surface is generally available once nothing gates it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
WAIT FORandWAIT UNTIL READYoptions onALTER CLUSTERare still gated byenable_zero_downtime_cluster_reconfigurationand documented as private preview. Graceful reconfiguration is now the standard path for managed cluster shape changes, so the gate only controls whether users can customize its deadline and timeout behavior.Description
Accept
ALTER CLUSTER ... WITH (WAIT ...)unconditionally and remove the feature flag. The existing validation remains in place forWAITon unmanaged clusters and forWAITwithout a replica shape change.Remove the private-preview labels from the
ALTER CLUSTERdocumentation and remove explicit flag setup from tests and workloads. LaunchDarkly may retain the removed flag temporarily, so the consistency test marks it as stale.Mixed-version tests can execute
WAITstatements against older binaries that still enforce the gate.get_minimal_system_parameterstherefore pins the flag on for binaries before v26.41.Verification
Existing sqllogictest, testdrive, cloudtest, platform-check, parallel-workload, and cluster mzcompose coverage now exercises the syntax without enabling the feature flag. The mixed-version system-parameter boundary is covered by the shared mzcompose configuration.